feat: allow empty header values for compatibility with STOMP 1.1 and 1.2 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 1.1 and 1.2 style: break terminated call across multiple lines
|
Also, I know you were looking for maintainers. I might be willing to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In STOMP 1.1 and 1.2, header values are defined as:
Where previously they were defined as:
Due to a quirk of the
not_line_endingandterminatedcombinators, the parser was failing on empty header values, of the formcorrelation-id:\n, due to thenot_line_endingcombinator not having enough input.This solution adds a single fallback tag to the terminated call, allowing it to gracefully parse empty values as "".