Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests expectation with ggplot2 3.5.0 #25

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Tests expectation with ggplot2 3.5.0 #25

merged 2 commits into from
Mar 13, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break assignPOP.

This PR updates a few tests in assignPOP to deal with the latest changes. In summary, the str(plot) object can change when ggplot2 changes its internals, making these tests fragile. These tests have been replaced to expect a ggplot object.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of Februari. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help assignPOP get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is just a kind reminder that we plan to release ggplot 3.5.0 soon.

@alexkychen alexkychen merged commit 50ce48d into alexkychen:master Mar 13, 2024
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch March 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants