Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Vitest, Support Vite 5 #255

Merged
merged 11 commits into from
Jan 6, 2024
Merged

Migrate to Vitest, Support Vite 5 #255

merged 11 commits into from
Jan 6, 2024

Conversation

alexlafroscia
Copy link
Owner

No description provided.

alexlafroscia and others added 5 commits December 30, 2023 14:11
BREAKING CHANGE: Versions of Vite older than `5.0.0` are no longer tested against or guaranteed to work
@alexlafroscia alexlafroscia changed the title migrate from Jest to Vitest Migrate to Vitest, Support Vite 5 Jan 4, 2024
@alexlafroscia
Copy link
Owner Author

I'm actively working on this, but getting tripped up because locally on macOS, the tests fail with a different error than is happening here in CI (something related to Rollup)

RollupError: The "fileName" or "name" properties of emitted chunks and assets must be strings that are neither absolute nor relative paths, received "../../../../../../private/var/folders/w7/n2r_44052ld652hqw5dbmz5c0000gn/T/vite-plugin-handlebars-sCoQqP/index.html".

It seems like this has something to do with the location that my testing utilities put the test fixtures that the tests build against, and I'm not sure how to resolve this yet.

BREAKING CHANGE: this package no longer works as a CommonJS import. If you need to use it from a CommonJS context, you can import it using `import()`
@alexlafroscia alexlafroscia force-pushed the migrate-to-vitest branch 4 times, most recently from 3fc2f4c to 2783b7d Compare January 6, 2024 16:34
@alexlafroscia alexlafroscia merged commit 0e1fffd into main Jan 6, 2024
10 checks passed
@alexlafroscia alexlafroscia deleted the migrate-to-vitest branch January 6, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants