Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional 2-pane mode and larger preview #33

Closed
noctuid opened this issue Apr 30, 2022 · 5 comments
Closed

Optional 2-pane mode and larger preview #33

noctuid opened this issue Apr 30, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@noctuid
Copy link

noctuid commented Apr 30, 2022

This is also minor. I love the 3-pane mode, but it might also be nice to be able to toggle into a 2-pane mode or make the preview area bigger. For example, in ranger, I have a key that toggles into 2 panes and makes the preview really big.
@alexluigit alexluigit added the enhancement New feature or request label May 3, 2022
@noctuid
Copy link
Author

noctuid commented May 6, 2022

A customizable pane ratio might also be nice (and could be used to handle the above cases). I currently use 1,3,5 for ranger. The middle pane is a little bigger in ranger, which helps fit long file names.

@alexluigit
Copy link
Owner

Please try out the dirvish-switch-layout command. The dirvish-setup-menu also get updated accordingly. Let me know what you think about them, thanks.

alexluigit added a commit that referenced this issue May 12, 2022
@alexluigit
feat(extras): add dirvish-switch-layout command (#33)
e40cc2d
alexluigit added a commit that referenced this issue May 13, 2022
@alexluigit
feat(extras): add dirvish-switch-layout command (#33)
7319791
alexluigit added a commit that referenced this issue May 17, 2022
@alexluigit
refactor(core): add dirvish-default-layout user option (#33)
e7ec4f3 
The old `dirvish-depth` + `dirvish-parent-max-width` + `dirvish-preview-width`
combination is pretty complex for users. We now use the concept 'layout recipe'
to rule them all. The `dirvish-default-layout` is much easier to understand and
is consistent with `dirvish-switch-layout` in dirvish-extras.el.
@alexluigit
Copy link
Owner

Also see the dirvish-default-layout user option.

@noctuid
Copy link
Author

noctuid commented May 22, 2022

Yes, this is perfect!

The dirvish-default-layout documentation might also link to dirvish-layout-recipes.

One question: It looks like long filenames are always truncated when only two panes are shown, even when "truncate long lines" is disabled. With three panes, the behavior depends on "truncate long lines." I prefer truncation, so this doesn't bother me, but do you know why this happens?

@noctuid noctuid closed this as completed May 22, 2022
@alexluigit
Copy link
Owner

alexluigit commented May 23, 2022 •
edited
Loading

It looks like long filenames are always truncated when only two panes are shown, even when "truncate long lines" is disabled. With three panes, the behavior depends on "truncate long lines."

This should has nothing to do with the pane numbers, have a look at the variable truncate-partial-width-windows.

tarsius pushed a commit to emacsmirror/dirvish that referenced this issue Aug 15, 2022
@alexluigit
feat(extras): add dirvish-switch-layout command (alexluigit#33)
6d94d4c 
Former-commit-id: 7319791
tarsius pushed a commit to emacsmirror/dirvish that referenced this issue Aug 15, 2022
@alexluigit
refactor(core): add dirvish-default-layout user option (alexluigit#33)
bc2baf9 
The old `dirvish-depth` + `dirvish-parent-max-width` + `dirvish-preview-width`
combination is pretty complex for users. We now use the concept 'layout recipe'
to rule them all. The `dirvish-default-layout` is much easier to understand and
is consistent with `dirvish-switch-layout` in dirvish-extras.el.


Former-commit-id: e7ec4f3
@alexluigit alexluigit mentioned this issue Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noctuid @alexluigit