Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isMergeableObject returns true for Map and Set #15

Closed
Lordfirespeed opened this issue Nov 1, 2024 · 0 comments · Fixed by #16
Closed

isMergeableObject returns true for Map and Set #15

Lordfirespeed opened this issue Nov 1, 2024 · 0 comments · Fixed by #16

Comments

@Lordfirespeed
Copy link
Contributor

This means that Map and Set values sourced from the script adapter end up being deserialized to {}, as Object.keys() returns [] for both Map and Set objects.
Lordfirespeed added a commit to Lordfirespeed/zod-config that referenced this issue Nov 1, 2024
@Lordfirespeed
fix: alexmarqs#15
244d3be
Lordfirespeed added a commit to Lordfirespeed/zod-config that referenced this issue Nov 1, 2024
@Lordfirespeed
fix: alexmarqs#15
fbf8b66
@Lordfirespeed Lordfirespeed mentioned this issue Nov 1, 2024
Merged
Lordfirespeed added a commit to ducompsoc/durhack that referenced this issue Nov 2, 2024
@Lordfirespeed
use z.record() instead of z.map() because of alexmarqs/zod-config#15
15b188a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only merge obviously record-like objects Lordfirespeed/zod-config
1 participant
@Lordfirespeed