forked from samuelcolvin/dirty-equals
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch pprint to make pytest diffs nicer for big objects #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
Hi! Thanks for the great tool. In our system, we run checks on the licences in the libraries we use and having `file` here adds some complexity in parsing. Would it be possible to have a certain license here, as proposed? --------- Co-authored-by: Samuel Colvin <s@muelcolvin.com>
This is not the same as samuelcolvin#71, but it originates at the same point. When I updated pytz to 2023.3.post1, I started getting: ``` E DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ``` This fixes it. --------- Co-authored-by: Samuel Colvin <s@muelcolvin.com>
…lcolvin#81) ...and a few other things that got in my way as an initial contributor. Closes samuelcolvin#33
fix samuelcolvin#72 Ended up having to do a bunch of things at the same time to get tests to pass: * drop 3.7 (added 3.12 at the same time) * uprev deps * uprev pydantic requirement to >2 * switch `IsUrl` to assume pydantic 2
samuelcolvin
pushed a commit
to samuelcolvin/dirty-equals
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes samuelcolvin#73
Based on the branch in samuelcolvin#81