-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Python 3.11 #25
Comments
The core problem of the two first tests is very likely related to: alexmojaki/executing#30 It seems that the patch from alexmojaki/executing#31 is not complete enough to make stack_data work with Python 3.11. |
Released support in stack_data 0.5.1 (along with executing 1.1.0 ofc) |
cc @aroberge |
@alexmojaki Many thanks. I have just checked it (with the newest executing version) with the existing tests I have for Python 3.6 to 3.11; I am still skipping many 3.11 tests as I have not touched the tests files. However, I did notice that the tests take about 2 to 3 times as long to run now for Python 3.6 to 3.10. They used to run in about 8 +/- 1 seconds. Now they take about 20 seconds. Of 400 or so tests, the longest one, that has many asserts by itself now takes more than 3 seconds. Caveat: I have been refactoring some parts of the code this morning and perhaps this is the source of the slowdown - even though I cannot see why that would be as the changes I made should have been neutral in terms of execution time. |
@aroberge this should probably be a new issue. Anyway, it should be easy to check what happens if you run the tests with executing versions 1.0.0 and 1.1.0 without changing your own code. |
Testing with executing 0.8.3 (which I had before), even with one now
failing test, it takes 5 seconds to run with Python 3.9.
I will try to investigate more later.
…On Sun, Sep 25, 2022 at 11:41 AM Alex Hall ***@***.***> wrote:
@aroberge <https://github.com/aroberge> this should probably be a new
issue. Anyway, it should be easy to check what happens if you run the tests
with executing versions 1.0.0 and 1.1.0 without changing your own code.
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZXQQ6RVCFYL27SVXD5WTWABQBLANCNFSM5R7W3VTQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hello.
It seems that stack_data is not compatible with Python 3.11 (alpha 6 currently). We are preparing RPM packages in Fedora with Python 3.11 and this one fails to build.
Complete results
The text was updated successfully, but these errors were encountered: