Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The value 0 isn't accepted #85

Closed
Kixunil opened this issue Aug 6, 2019 · 2 comments · Fixed by #87 or #104
Closed

The value 0 isn't accepted #85

Kixunil opened this issue Aug 6, 2019 · 2 comments · Fixed by #87 or #104
Labels
bug nc
Milestone
Release 0.1.2nc

Comments

@Kixunil
Copy link
Contributor

Kixunil commented Aug 6, 2019

Describe the bug
When value 0 is submitted, there's error message "value needs to be an integer or float"

To Reproduce
Steps to reproduce the behavior:

  1. Register a device with extended API
  2. Submit value 0
  3. See error

Expected behavior
Value 0 is successfully logged

Additional context
I use multiple values, first one is float, second one is int.
@alexstocker
Copy link
Owner

@Kixunil
Thanx for reporting. Bug confirmed. Will be fixed asap

@alexstocker alexstocker added this to the Release 0.1.2nc milestone Aug 7, 2019
Kixunil added a commit to Kixunil/sensorlogger that referenced this issue Aug 9, 2019
@Kixunil
Change the value check to use is_numeric
7d15c46 
Fixes alexstocker#85
@Kixunil Kixunil mentioned this issue Aug 9, 2019
Merged
@Kixunil
Copy link
Contributor Author

Kixunil commented Aug 9, 2019

I found the solution - see the PR.

alexstocker added a commit that referenced this issue Nov 1, 2019
@alexstocker
#89 add NC17 support, #86, #85
862f3b6
alexstocker added a commit that referenced this issue Oct 20, 2020
@alexstocker
#85 Allow 0 value @Kixunil
22fbc91
alexstocker pushed a commit that referenced this issue Dec 15, 2021
Prepare SensorLogger for owncloud 0.1.1 Update Release Ref. #101 #11 #51
10a74fa 
 #85
@alexstocker alexstocker mentioned this issue Dec 16, 2021
Merged
@alexstocker alexstocker linked a pull request Dec 16, 2021 that will close this issue
Update Release 0.1.1 #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug nc
Projects
None yet
Milestone
Release 0.1.2nc
2 participants
@Kixunil @alexstocker