Removed createElement; use HTMLVideoElement.prototype instead #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alextrv This script shall be maintained even in 2023. YouTube still wants my Macbook M1 Pro using WiFi plays 360p instead of 1080p.
According to Youtube's
desktop_polymer.js, some coding shall be updated as the very old browsers are no longer supported.For example,
document.createElement('video').__proto__shall change toHTMLVideoElement.prototypeThis avoid unnecessary element creation (although not attached to the document), and also avoid
.bind()which create another instance of function.