Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the CodeIgniter fork from the composer.json file and re-import the system directory. #1109

Closed
h-e-l-l-o-w-o-r-l-d opened this issue Aug 20, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@h-e-l-l-o-w-o-r-l-d
Copy link

Hi,

I need to patch EA here and there so I installed it via

composer require alextselegidis/easyappointments:^1.4

in a project directory, where EA is stored in the vendor folder. This works. Wondered why it didn't fetch 1.4.2 so I required it explicitely with

composer require alextselegidis/easyappointments:1.4.2

and this error occurs:

Problem 1
- Root composer.json requires alextselegidis/easyappointments 1.4.2 -> satisfiable by alextselegidis/easyappointments[1.4.2].
- alextselegidis/easyappointments 1.4.2 requires codeigniter/framework dev-3.1.11-php8.0 -> found codeigniter/framework[dev-feature/email-attachment-charset, dev-develop, dev-3.1-stable, 3.0rc, ..., 3.1.11] but it does not match the constraint.

composer.json is like this:

{
"require": {
"alextselegidis/easyappointments": "^1.4",
"cweagans/composer-patches": "^1.0"
},
"extra":{
"patches-file": "composer.patches.json",
"enable-patching": true
},
"config": {
"sort-packages": true
},
"minimum-stability": "dev",
"prefer-stable": true
}

Any hints what might be wrong?

@alextselegidis
Copy link
Owner

Hello @h-e-l-l-o-w-o-r-l-d,

Thanks for posting this, I will take a look and get back to you.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

@alextselegidis
Copy link
Owner

I could reproduce the problem is happening while trying to include Easy!Appointments as a composer package into another project.

I'm working on a solution.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

@alextselegidis alextselegidis self-assigned this Aug 24, 2021
@alextselegidis alextselegidis added the bug Something isn't working label Aug 24, 2021
@alextselegidis alextselegidis added this to the v1.5.0 milestone Aug 24, 2021
@alextselegidis
Copy link
Owner

Alright, I had to re-introduce the system directory into the root directory and remove it from vendor.

The reason behind this is that the CodeIgniter team hasn't yet released a new version that includes the PHP8 required fixes that are needed for Easy!Appointments to work flawlessly.

In any case this change also made the Easy!Appointments package much smaller, which is a good thing.

It will be released with 1.5.0, so stay tuned for future updates.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

alextselegidis added a commit that referenced this issue Aug 24, 2021
@alextselegidis
Copy link
Owner

FYI for now you can composer require alextselegidis/easyappointments:dev-develop

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

alextselegidis added a commit that referenced this issue Oct 18, 2021
@alextselegidis alextselegidis changed the title Problem installing 1.4.2 with composer Remove the CodeIgniter fork from the composer.json file and re-import the system directory. Oct 22, 2021
stonerl pushed a commit to international-office-ut/easyappointments that referenced this issue Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants