Handle super-read-only the same way as read-only errors #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfa-jpn
requested changes
May 3, 2020
There was a problem hiding this comment.
Sorry for the late reply.
Thanks for great PR!
Please check some comments. 🙏
Also, Can you write a test code?
https://github.com/alfa-jpn/mysql2-aurora/blob/master/spec/mysql2/aurora_spec.rb#L88
| @@ -19,6 +19,11 @@ def initialize(opts) | |||
| reconnect! | |||
| end | |||
|
|
|||
| def read_only_error?(msg) | |||
There was a problem hiding this comment.
nits: Please write a comment with yard format 🙏
Comment on lines
+23
to
+24
| return false if msg.nil? | ||
| msg.include?('--read-only') || msg.include?('--super-read-only') |
There was a problem hiding this comment.
imho: I think this is better, but how about it?
!msg.nil? && ['--read-only', '--super-read-only'].any? { |term| msg.include?(term) }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to include
--super-read-onlyerrors in the criteria for deciding to attempt a reconnect.