Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tuning #14

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Fine tuning #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698ed33
Renamed BPMProcessOperations as BPMProcessInstanceOperations
janihaglund Feb 7, 2022
4f4eaf3
Made deletion reason optional
janihaglund Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mule-bpm-module/src/main/java/com/alfame/esb/bpm/module/internal/BPMExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import com.alfame.esb.bpm.module.internal.operations.BPMAttachmentOperations;
import com.alfame.esb.bpm.module.internal.operations.BPMEventSubscriptionOperations;
import com.alfame.esb.bpm.module.internal.operations.BPMProcessFactoryOperations;
import com.alfame.esb.bpm.module.internal.operations.BPMProcessOperations;
import com.alfame.esb.bpm.module.internal.operations.BPMProcessInstanceOperations;
import com.alfame.esb.bpm.module.internal.operations.BPMProcessVariableOperations;
import org.flowable.common.engine.api.FlowableIllegalArgumentException;
import org.flowable.common.engine.api.FlowableObjectNotFoundException;
Expand Down Expand Up @@ -57,7 +57,7 @@
@Extension(name = "BPM", vendor = "Alfame Systems")
@Sources(BPMTaskListener.class)
@ConnectionProviders(BPMConnectionProvider.class)
@Operations({BPMProcessFactoryOperations.class, BPMProcessVariableOperations.class, BPMEventSubscriptionOperations.class, BPMAttachmentOperations.class, BPMProcessOperations.class})
@Operations({BPMProcessFactoryOperations.class, BPMProcessVariableOperations.class, BPMEventSubscriptionOperations.class, BPMAttachmentOperations.class, BPMProcessInstanceOperations.class})
@SubTypeMapping(baseType = BPMDefinition.class,
subTypes = {BPMClasspathDefinition.class, BPMStreamDefinition.class})
@SubTypeMapping(baseType = BPMDataSource.class,
Expand Down
7 changes: 4 additions & 3 deletions ...rnal/operations/BPMProcessOperations.java → ...rations/BPMProcessInstanceOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,18 @@

import org.mule.runtime.extension.api.annotation.Alias;
import org.mule.runtime.extension.api.annotation.param.Config;
import org.mule.runtime.extension.api.annotation.param.Optional;
import org.mule.runtime.extension.api.annotation.param.display.DisplayName;
import org.slf4j.Logger;

public class BPMProcessOperations {
private static final Logger LOGGER = getLogger(BPMProcessOperations.class);
public class BPMProcessInstanceOperations {
private static final Logger LOGGER = getLogger(BPMProcessInstanceOperations.class);

@Alias("delete-process-instance")
public void deleteProcessInstance(
@Config BPMExtension config,
@DisplayName("Process instance Id") String processInstanceId,
@DisplayName("Delete reason") String deleteReason) throws IOException {
@Optional @DisplayName("Delete reason") String deleteReason) throws IOException {

config.deleteProcessInstance(processInstanceId, deleteReason);

Expand Down