Skip to content

Commit

Permalink
Disable CheckInlineValueIsComplete for Fable (dotnet#10)
Browse files Browse the repository at this point in the history
  • Loading branch information
alfonsogarciacaro authored and ncave committed Aug 26, 2022
1 parent 7e16148 commit 32ff3a3
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/Compiler/Optimize/Optimizer.fs
Original file line number Diff line number Diff line change
Expand Up @@ -494,10 +494,18 @@ let rec IsPartialExprVal x =
| ValValue (_, a)
| SizeValue(_, a) -> IsPartialExprVal a

#if FABLE_CLI
// Many Fable packages inline functions that access internal values to resolve generics, this is not an issue
// in "normal" Fable compilations but it raises errors when generating an assembly por precompilation. Disable
// for Fable as it's not an actual error (and if is, we assume it's already been raised during type chedking).
let CheckInlineValueIsComplete (_v: Val) _res =
()
#else
let CheckInlineValueIsComplete (v: Val) res =
if v.MustInline && IsPartialExprVal res then
errorR(Error(FSComp.SR.optValueMarkedInlineButIncomplete(v.DisplayName), v.Range))
//System.Diagnostics.Debug.Assert(false, sprintf "Break for incomplete inline value %s" v.DisplayName)
#endif

let check (vref: ValRef) (res: ValInfo) =
CheckInlineValueIsComplete vref.Deref res.ValExprInfo
Expand Down

0 comments on commit 32ff3a3

Please sign in to comment.