Clean up grammars #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great @texastoland, thanks a lot! Please let me know when it's ready to test. It'd be great if we can replace the comment command automatically. I'm currently adding an extra command (Ctrl+K+C) but it's not ideal. |
The main grammar works perfectly. Child grammars are applied. But negatively interact with each other.
alfonsogarciacaro
force-pushed
the
master
branch
from
8004eb2
to
95455bc
Compare
|
I want to redo this PR. It was too big to review and you were adding stuff I'd revert. I prefer smaller PRs on an experimental branch. I could either add you as a reviewer in my fork or you create a Sound okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally began in order to fix #2. Expanded to close #4. Improves maintainability in general. Bullet points in individual commits. I still have a few commits incoming to add supplementary grammars and remove the comment commands (that's what
embeddedLanguagesactually does).CC @AngelMunoz