Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gzip + chunk pool problem #550

Closed
wants to merge 6 commits into from
Closed

Fix gzip + chunk pool problem #550

wants to merge 6 commits into from

Commits on Oct 18, 2022

  1. Configuration menu
    Copy the full SHA
    b513104 View commit details
    Browse the repository at this point in the history
  2. Feature gate test

    algesten committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    9355a8b View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. gzip/brotli make sure wrapped stream reads to n=0

    This commit adds two intermediary wrappers to the gzip/brotli decoding
    cases, DidReadZero and CompressionRead.
    
    The inner, DidReadZero, keeps track of whether the wrapped stream has
    read to n=0. The wrapped stream will typically be a
    `PoolReturnRead(ChunkedDecoder)` or `PoolReturnRead(LimitRead)`, both
    which are fine to read multiple times to 0.
    
    The outher CompressionRead will on n=0 unpack the inner DidReadZero
    and ensure we do read to 0.
    algesten committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    8f06cf8 View commit details
    Browse the repository at this point in the history
  2. fix clippy

    algesten committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d1f55ed View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. gzip/brotli make sure wrapped stream has exactly n=0

    This commit adds two intermediary wrappers to the gzip/brotli decoding
    cases, DidReadZero and PreciseRead.
    
    The inner, DidReadZero, keeps track of whether the wrapped stream has
    read to n=0. The wrapped stream will typically be a
    `PoolReturnRead(ChunkedDecoder)` or `PoolReturnRead(LimitRead)`, both
    which are fine to read multiple times to 0.
    
    The outher PreciseRead will on n=0 unpack the inner DidReadZero
    and ensure it reads exactly nothing one more time.
    algesten committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    5d8c8dc View commit details
    Browse the repository at this point in the history
  2. Remove unused struct

    algesten committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f692ed2 View commit details
    Browse the repository at this point in the history