Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't panic when rustls-native-certs errors #564

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Don't panic when rustls-native-certs errors #564

merged 3 commits into from
Dec 1, 2022

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Nov 28, 2022

Fixes #563

algesten
algesten approved these changes Nov 28, 2022
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny thing.

Thanks!

src/rtls.rs Outdated

root_store
if valid_count == 0 && invalid_count > 0 {
error!("no valid certificates loaded by rustls-native-certs. all HTTP requests will fail.");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTPS?

@wolthom wolthom mentioned this pull request Nov 29, 2022
Closed
@jsha jsha merged commit cf68738 into algesten:main Dec 1, 2022
@jsha jsha deleted the fix-der-panic branch December 1, 2022 06:38
@reupen reupen mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AgentBuilder::new panics (possibly because of ill-formed certificates)
2 participants
@jsha @algesten