Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ“ Update tooltip #980

Conversation

treasurechic
Copy link
Contributor

β„Ή Overview

closes #979

πŸ“ Related Issues

πŸ” Acceptance:

  • yarn test passes

@vercel
Copy link

vercel bot commented Feb 23, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
algodex-react-dev βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Feb 24, 2023 at 2:40PM (UTC)

Copy link
Collaborator

@ericsharma ericsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing the tooltip message inline can you keep them in a separate file? Then we can import the tooltip messages into CreateToken.tsx and call them like
<Tip tip={tooltip.clawbackAddr} /> which is more readable

Copy link
Collaborator

@ericsharma ericsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new file for the tooltips and import them into CreateToken.tsx

@ericsharma ericsharma merged commit e0f17dc into 942-feature-algodex-launchpad-for-creating-and-listing-asas Feb 24, 2023
@ericsharma ericsharma deleted the 979-update-tooltips-for-optional-input-fields-in-createtoken-component branch February 24, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants