Skip to content

995 create new type for an activewallet object #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2023
Merged

995 create new type for an activewallet object #996

merged 2 commits into from
Mar 6, 2023

Conversation

treasurechic
Copy link
Contributor

@treasurechic treasurechic commented Mar 2, 2023 •
edited
Loading

ℹ Overview

close #995

📝 Related Issues

🔐 Acceptance:

  • yarn test passes

@treasurechic treasurechic requested a review from ericsharma March 2, 2023 16:08
@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
algodex-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 4:48PM (UTC)

ericsharma
ericsharma requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@ericsharma ericsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treasurechic This branch includes commits related to the searchtable which is still an open PR. Can you delete this branch and open a PR that has #942 as the origin?

@treasurechic
Copy link
Contributor Author

@treasurechic This branch includes commits related to the searchtable which is still an open PR. Can you delete this branch and open a PR that has #942 as the origin?

I thought the search table PR is sorted, what is left pending?

@ericsharma
Copy link
Collaborator

ericsharma commented Mar 2, 2023 •
edited
Loading

I thought the search table PR is sorted, what is left pending?

@treasurechic We are waiting for @stephclarkga feedback regarding the columns for the search table and whether or not we need to change the columns in the search table depending on whether you are managing a token or creating/managing a token sale. You can see my latest comment on the PR for more information

@treasurechic
Copy link
Contributor Author

I thought the search table PR is sorted, what is left pending?

@treasurechic We are waiting for @stephclarkga feedback regarding the columns for the search table and whether or not we need to change the columns in the search table depending on whether you are managing a token or creating/managing a token sale. You can see my latest comment on the PR for more information

Oh, alright. Will wait on that then👍🏽

@treasurechic treasurechic requested a review from ericsharma March 3, 2023 16:48
@ericsharma ericsharma merged commit ef6df00 into 942-feature-algodex-launchpad-for-creating-and-listing-asas Mar 6, 2023
@ericsharma ericsharma deleted the 995-create-new-type-for-an-activewallet-object branch March 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsharma ericsharma ericsharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treasurechic @ericsharma