Issue 226 ✅ acceptance add tests for all the different order types #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do fully test, need to bring back the 'beforeAll' tests
…-transaction-types-to-user-sdk-v2-transaction-generators 231 acceptance refactor generate transaction types to user sdk v2 transaction generators
…-the-different-order-types 226 acceptance add tests for all the different order types
✨ Test passing for placeAlgoWithOptIn using v2
…t-in-txn 236 teal algo escrow place no opt in txn
✨Cancel ASA set up and test complete
✨ Closing Order and cleanupStep for TealAsaEscrowPlace
243 cleanup teal algo escrow place
…no-opt-in-txn ✅Passing tests for asaPartialExecutiuon no optin
…row-pay-partial-with-no-opt-in ✨Cleanup step for partial execution no optin
…all_the_different_order_types
…_different_order_types
…k-the-state-before-passing-order-into-taker-execution-tests ✅: 284 fetch the orderbook and check the state before passing order into taker execution tests
…opt-in ✅ Passing test for TealAsaEscrowPayCloseoutNoOptInTxn
288 teal algo escrow cancel
…what they are testing for
…n-to-take-an-optional-note-parameter ✨ 290 edit account setup function to take an optional note parameter
…andardize-naming-across-different-tests 292 improve documentation and standardize naming across different tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…before-testing 295 randomly generate the asset before testing
atrefonas
approved these changes
Oct 19, 2022
…_different_order_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
This PR addresses the positive teal tests for every transaction type. The new positive tests use the SDK to generate the transactions so an added benefit is increased code coverage for the SDK.
✏️ Things to note:
Make sure to set
autoRun: falseif your workspace is configured to automatically run tests. Because all the positive teal tests work on a single orderbook, running the tests all at once leads to complications. It doesn't matter which order you run the tests in, just make sure you are only running one at a time.Also anything related to taker execution depends on the assumption that the orderbook is empty at the beginning of the test.
Check the state of the orderbook and close out any open orders if they exist before running any taker execution test.
After extensively running the tests, every once in a while one will fail. This is the result of our backend throwing a 404 every once in a while. This does not happen frequently, but if a test does fail, it is most likely related to that issue. To address the failing test, first check the state of the orderbook and close out any open orders if they exist, then re-run the test.
📝 Related Issues
#226