-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fall-through in switch #3
Allow fall-through in switch #3
Conversation
Moved opcode number to be by other "strange jumps" Added simple tests for normal cases, and for fallthrough Added some overflow protection from handcrafted bytecode by limiting switch labels to 2^16.
Feedback on algoidurovic#3 for switchi fall-through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to bump up the doc version here or later down the road? It looks like the docs weren't regenerated:
var docVersion = 7 // -> change to 8
Made some changes to cast the label count (numOffsets) to `int` sooner. My bug was multiplying numOffsets by 2 while it was still a byte and _then_ casting to int. It had already wrapped.
I think all we need to do first is make sure that devrel (or whoever does it) has taken the v7 docs and put them in place for public consumption. |
@jannotti https://github.com/algorand/docs/blob/staging/docs/get-details/dapps/avm/teal/specification.md looks updated to me. As a live proof point, opcodes look updated: https://developer.algorand.org/docs/get-details/dapps/avm/teal/opcodes/. The repo recently introduced Github Actions to automatically generate PRs when there's upstream (go-algorand, indexer) releases: https://github.com/algorand/docs/blob/staging/.github/workflows/release-checker.yml. Due to the auto PR generation, I think we want to hold on merging updated docs to |
I bumped the docVersion, moved pairing ops to 9, and put in the v9 nonsense test. |
Moved opcode number to be by other "strange jumps"
Added simple tests for normal cases, and for fallthrough