Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search.IndexInterface missing Exists() #537

Closed
i0exception opened this issue Aug 21, 2019 · 1 comment
Closed

search.IndexInterface missing Exists() #537

i0exception opened this issue Aug 21, 2019 · 1 comment

Comments

@i0exception
Copy link

search.IndexInterface is missing the Exists() function - could this be added? makes mocking easier.

#513 changed index.go but not index_interface.go
aseure added a commit that referenced this issue Aug 21, 2019
@aseure
fix(index): add missing Exists() method to the IndexInterface (#537)
989e0a7 
[changelog]

Because the Exists() method was missing, the Index could not be mocked
as expected.
aseure added a commit that referenced this issue Aug 21, 2019
@aseure
fix(index): add missing Exists() method to the IndexInterface (#537)
c1812b9 
[changelog]

Because the Exists() method was missing, the Index could not be mocked
as expected.
@aseure
Copy link

aseure commented Aug 21, 2019

@i0exception Thank you for opening this issue. Great catch indeed. I've just fixed it in #538 and it's now released in v3.2.1. You should be able to update now!

Have a nice day.

@aseure aseure closed this as completed Aug 21, 2019
mehmetaligok pushed a commit that referenced this issue May 3, 2023
@shortcuts
fix(scripts): update release issue process (#537)
7f6cf20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@i0exception @aseure