Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: insights events are missing fields such as price, currency and objectData #767

Closed
vredens opened this issue Sep 25, 2024 · 2 comments
Closed

[bug]: insights events are missing fields such as price, currency and objectData #767

vredens opened this issue Sep 25, 2024 · 2 comments
Assignees
@Fluf22

Comments

@vredens
Copy link

vredens commented Sep 25, 2024

Description

Insights Events type is missing parameters when compared to the API spec https://www.algolia.com/doc/rest-api/insights/#tag/events/operation/pushEvents

  • objectData
  • price
  • currency

and others.

This is preventing us to push this information to Algolia's insights API.

Client

Insights

Version

3

Relevant log output

No response
@vredens vredens changed the title [bug]: [bug]: insights events are missing fields such as price, currency and objectData Oct 8, 2024
@jkaho
Copy link
Contributor

jkaho commented Oct 9, 2024 •
edited
Loading

@vredens hello! The latest version of the client should include the correct fields. Is there a reason you're unable to upgrade to v4?

@Fluf22 Fluf22 self-assigned this Nov 12, 2024
@Fluf22 Fluf22 mentioned this issue Nov 13, 2024
Merged
Fluf22 added a commit that referenced this issue Nov 13, 2024
@Fluf22
fix(insights): add missing props (#768)
e3f2a86 
## What
Add missing props to the Insights event type

## Note
Some props are not strongly typed because they can be multiple things
(usually string or number)
In the future, we should allow extracting data from the opts variadic
param

fixes #767
@Fluf22
Copy link
Contributor

Fluf22 commented Nov 14, 2024

@vredens hey 👋🏻 sorry we took so long to address the missing properties.
Tell me if something else is wrong!

Please note that some of these props are not strongly typed because they are polymorphic.
As a reminder: https://www.algolia.com/doc/rest-api/insights/#tag/events/operation/pushEvents

@Fluf22 Fluf22 closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vredens @Fluf22 @jkaho