Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add hide in renderingContent facet values #1529

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

thomasbritton
Copy link

@thomasbritton thomasbritton commented Jun 21, 2024

Adds typing for the new hide property in renderingContent facet values

JIRA ticket: https://algolia.atlassian.net/browse/EMERCH-1518

@thomasbritton thomasbritton self-assigned this Jun 21, 2024
@thomasbritton thomasbritton marked this pull request as ready for review June 21, 2024 09:51
@thomasbritton thomasbritton requested review from aymeric-giraudet, shortcuts, a team and sarahdayan and removed request for a team June 21, 2024 09:56
@thomasbritton
Copy link
Author

The failing tests seem unrelated, are they flakey?

Copy link
Member

@aymeric-giraudet aymeric-giraudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! And yes the tests are flakey @thomasbritton, gotta rerun them :/

@thomasbritton
Copy link
Author

thomasbritton commented Jun 21, 2024

Looks good ! And yes the tests are flakey @thomasbritton, gotta rerun them :/

I have re-run 5 times not passing still @aymeric-giraudet

@shortcuts
Copy link
Member

hey @thomasbritton yes it fails aaaa looooot (can't wait to move to https://github.com/algolia/api-clients-automation), it might not be flakiness at this point, I think something is broken, i'll try to fix it on monday

@thomasbritton
Copy link
Author

hey @thomasbritton yes it fails aaaa looooot (can't wait to move to https://github.com/algolia/api-clients-automation), it might not be flakiness at this point, I think something is broken, i'll try to fix it on monday

Hey @shortcuts , I'm trying it once more for luck! But thank you for your support on this.

@thomasbritton
Copy link
Author

Hey @shortcuts , just wondering if you have been able to have a look at this yet?

@shortcuts
Copy link
Member

trying right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants