-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): add hide in renderingContent facet values #1529
Conversation
The failing tests seem unrelated, are they flakey? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! And yes the tests are flakey @thomasbritton, gotta rerun them :/
I have re-run 5 times not passing still @aymeric-giraudet |
hey @thomasbritton yes it fails aaaa looooot (can't wait to move to https://github.com/algolia/api-clients-automation), it might not be flakiness at this point, I think something is broken, i'll try to fix it on monday |
Hey @shortcuts , I'm trying it once more for luck! But thank you for your support on this. |
Hey @shortcuts , just wondering if you have been able to have a look at this yet? |
trying right now |
Adds typing for the new
hide
property in renderingContent facet valuesJIRA ticket: https://algolia.atlassian.net/browse/EMERCH-1518