MAGE-957: js and css reorged. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
requested changes
Aug 5, 2024
damcou
left a comment
damcou
left a comment
There was a problem hiding this comment.
Looks fine !
Maybe we should put the autocomplete-plugin-recent-searches.js file in an internals folder as we did in the extension ? WDYT ?
Contributor
Author
|
That's a good idea to be consistent. Thanks for pointing it out. |
cammonro
requested changes
Aug 12, 2024
Contributor
cammonro
left a comment
cammonro
left a comment
There was a problem hiding this comment.
@mrahman3177 Let's bump this to version 1.3 and tag it with a ^3.14.0 dependency on the main module algolia/algoliasearch-magento-2.
cammonro
requested changes
Aug 12, 2024
Contributor
cammonro
left a comment
cammonro
left a comment
There was a problem hiding this comment.
@mrahman3177 Let's be sure to bump the version whenever we merge to master. I'm thinking we should bump by a minor version for every minor version in the main extension. 1.3.0 since we just released 3.14.0. WDYT?
composer.json
Outdated
| "license": [ | ||
| "MIT" | ||
| ], | ||
| "version": "1.2.2", |
Contributor
There was a problem hiding this comment.
Suggested change
| "version": "1.2.2", | |
| "version": "1.3.0", |
cammonro
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
js and css reorganized.