MAGE-1002: algoliaBundle removed #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammonro
requested changes
Sep 3, 2024
| 'algoliaAnalytics', | ||
| 'algoliaQuerySuggestionsPluginLib', | ||
| 'suggestionsHtml', | ||
| 'algoliaRecentSearches', |
Contributor
There was a problem hiding this comment.
algoliaRecentSearches was previously packaged with the CustomAlgolia extension as a demo but it's actually in the bundle we are unpacking. I think it would be good if we could sync this module with that upcoming change and include a reference to the new location. We should probably adopt the new naming convention too I think?
cammonro
changed the base branch from
master
to
epic/MAGE-997-sunset-algolia-bundle
cammonro
approved these changes
Sep 3, 2024
Contributor
cammonro
left a comment
cammonro
left a comment
There was a problem hiding this comment.
Rescoped additional effort under MAGE-1020.
Contributor
|
Rebased PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
algoliaBundle removed.