Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass set product website_id to load catalogrule prices with enabled customer groups #853

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

unicoder88
Copy link
Contributor

Summary

We have a catalog rule that gives customer group "Blogger" discount to virtual products. We tried activating customer groups in Algolia module settings and reindexing, but all prices were exported as regular final price, blogger discounts not visible.

As it turns out, admin even observer applies catalogrule prices given assigned customer_group_id and website_id. However, website_id was not passed and so observer does nothing.

See ProcessAdminFinalPriceObserver.

Thank you :)

Result

@0livier 0livier changed the base branch from master to develop September 14, 2019 11:46
@bsuravech bsuravech added this to the 1.12.1 milestone Oct 9, 2019
@damcou damcou self-requested a review October 10, 2019 09:58
@damcou damcou merged commit af04c5a into algolia:develop Oct 10, 2019
@damcou
Copy link
Contributor

damcou commented Oct 10, 2019

Good catch @unicoder88 and thanks a lot for your contribution.
Your fix will be available in our next release ! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants