Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version to 1.12.1 for unsubscribe Mview migration (PR #870) #901

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fix version to 1.12.1 for unsubscribe Mview migration (PR #870) #901

merged 2 commits into from
Oct 28, 2019

Conversation

vmalyk
Copy link
Contributor

@vmalyk vmalyk commented Oct 26, 2019 •
edited
Loading

Summary

Migration isn't applied for installed version 1.12.0 and fix won't be worked after upgrade to 1.12.1 or higher.

Result
Changed version for migration to 1.12.1 ( the same version as set in PR`s milestone field)

@vmalyk
Copy link
Contributor Author

vmalyk commented Oct 26, 2019

@bsuravech, please review this PR.

Thank you!

@damcou damcou self-assigned this Oct 28, 2019
@damcou damcou added this to the 1.12.1 milestone Oct 28, 2019
damcou
damcou approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @vmalyk , usually we upgrade the setup version in the bump branch but I guess it's worth doing it there ;)

@damcou damcou merged commit 3465a2a into algolia:develop Oct 28, 2019
@vmalyk vmalyk deleted the fix/update-schema-version-fix branch October 29, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees

@damcou damcou

Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vmalyk @damcou