Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng update to Angular 7 : "Cannot read property 'split' of null" likely related to angular-instantsearch package #320

Closed
wduville opened this issue Oct 24, 2018 · 3 comments
Closed

ng update to Angular 7 : "Cannot read property 'split' of null" likely related to angular-instantsearch package #320

wduville opened this issue Oct 24, 2018 · 3 comments
Assignees
@tkrugg

Comments

@wduville
Copy link
Contributor

wduville commented Oct 24, 2018 •
edited
Loading

Versions

  • @angular/cli: 6.2.3 and 7.0.2, 7.0.3
  • @angular/core : 6.1.10
  • angular-instantsearch: "^2.0.4"
  • OS: Windows 10 x64
  • node: v8.11.2
  • npm: 6.4.1

Repro steps

With @angular/core : 6.1.10
Having "angular-instantsearch": "^2.0.4" under "dependencies" of package.json,
Run the command: ng update @angular/core

The log given by the failure

Only got this one line:
Cannot read property 'split' of null

Workaround

Temporarily remove "angular-instantsearch": "^2.0.4" from package.json, allows the update to proceed. After the update, put it back and run npm install
@Haroenv
Copy link
Contributor

Haroenv commented Oct 25, 2018

Hey! Would it be possible to create a sandbox with the exact setup you have? It will be easier to get to the source of the bug.

@tkrugg tkrugg self-assigned this Oct 25, 2018
@wduville
Copy link
Contributor Author

Sure ! Attached.
my-app_ng_update_@angular_core_fails.zip

The repro steps are:

  • ng new my-app
  • add "angular-instantsearch": "^2.0.4" dependency in package.json,
  • ng update @angular/core -> Fail with Cannot read property 'split' of null

PS: I edited the comment above with node (v8) and npm versions.
PS2: This bug has been reported here angular/angular-cli#12644 as well

tkrugg added a commit to tkrugg/angular-instantsearch that referenced this issue Oct 29, 2018
@tkrugg
fix(peerDependencies): allow peer dependencies >=5.0.0 <8.0.0
779c421 
- removed malformed >=^5.0.0 syntax
- added support for v7

Fixes algolia#320
Closes algolia#306
@tkrugg tkrugg closed this as completed in 3bfea08 Oct 30, 2018
@tkrugg
Copy link
Contributor

tkrugg commented Oct 31, 2018

For anyone running into this issue, you can now update to angular-instantsearch@2.1.0 before running ng update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tkrugg tkrugg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tkrugg @Haroenv @wduville