-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(clients): add ACL section to code doc #2576
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Huuuuuuge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that's the best option for Swift, because it removes a useful short description for some operations.
But this can be looked at later!
🧭 What and Why
As suggested by @morganleroi and @shortcuts, we can add the required ACLs to the clients doc, above each function.
We can't do that by simply adding it to the
{{notes}}
because each language has it's own way to handle multiline comments.I didn't do java for now, because the javadoc is messed up, will do it in another PR