Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(csharp): add logs and logger factory #2640

Merged
merged 4 commits into from
Jan 31, 2024
Merged

feat(csharp): add logs and logger factory #2640

merged 4 commits into from
Jan 31, 2024

Conversation

morganleroi
Copy link
Contributor

@morganleroi morganleroi commented Jan 30, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1731

Changes included:

  • Add logger factory extension.

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ca54900
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65ba42b6bce3cd00097bc5cc
😎 Deploy Preview https://deploy-preview-2640--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@morganleroi morganleroi changed the title add logs feat(csharp): add logs and logger factory Jan 30, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 30, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@morganleroi morganleroi marked this pull request as ready for review January 30, 2024 12:37
@morganleroi morganleroi requested a review from a team as a code owner January 30, 2024 12:37
@morganleroi morganleroi requested review from damcou and Fluf22 January 30, 2024 12:37
millotp
millotp reviewed Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice !

templates/csharp/netcore_project.mustache Outdated Show resolved Hide resolved
millotp
millotp approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@morganleroi morganleroi merged commit e4ab486 into main Jan 31, 2024
18 checks passed
@morganleroi morganleroi deleted the feat/csharp-add-logger branch January 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@Fluf22 Fluf22 Awaiting requested review from Fluf22 Fluf22 is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morganleroi @algolia-bot @millotp