feat(csharp): add performances playground #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
morganleroi
force-pushed
the
feat/csharp-performances
branch
from
5cb3d2a to
9086f9e
Compare
…eat/csharp-performances
millotp
reviewed
Feb 6, 2024
| } | ||
|
|
||
| return new UriBuilder { Scheme = "https", Host = url, Path = path }.Uri; | ||
| return new UriBuilder { Scheme = host.Scheme.ToString(), Host = host.Url, Port = host.Port, Path = path }.Uri; |
There was a problem hiding this comment.
is the port always defined ?
There was a problem hiding this comment.
if it's -1 maybe it shouldn't be passed
millotp
reviewed
Feb 6, 2024
| } | ||
|
|
||
| return new UriBuilder { Scheme = "https", Host = url, Path = path }.Uri; | ||
| return new UriBuilder { Scheme = host.Scheme.ToString(), Host = host.Url, Port = host.Port, Path = path }.Uri; |
There was a problem hiding this comment.
if it's -1 maybe it shouldn't be passed
millotp
reviewed
Feb 7, 2024
Fluf22
reviewed
Feb 7, 2024
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <RootNamespace>Performaces</RootNamespace> |
There was a problem hiding this comment.
Still a typo 😄
Suggested change
| <RootNamespace>Performaces</RootNamespace> | |
| <RootNamespace>Performances</RootNamespace> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
This PR adds a Performance project in the Playground. This performance test helps us finding bugs fetching real-world data. That's why a lot of tiny changes are included in this PR.
🎟 JIRA Ticket: DI-1717