Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp): correctly clean code gen #2676

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

morganleroi
Copy link
Contributor

@morganleroi morganleroi commented Feb 7, 2024

🧭 What and Why

Correctly remove Models and Api client before gen

🎟 JIRA Ticket: DI-1811

⚠️ fsp.rm do not seems to correctly manage wildcard. Deleting a folder works well, deleting files using wildcard does not.

@morganleroi morganleroi requested a review from a team as a code owner February 7, 2024 16:44
@morganleroi morganleroi requested review from damcou and Fluf22 February 7, 2024 16:44
Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 29be370
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65c3b37db64bf90008e07f7c
😎 Deploy Preview https://deploy-preview-2676--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 7, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lezzzzzz go

@morganleroi morganleroi merged commit 31e43d2 into main Feb 7, 2024
27 checks passed
@morganleroi morganleroi deleted the refactor/csharp-removeExistingCode branch February 7, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants