-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): improve API reference documentation #2831
Merged
Merged
Changes from 15 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5eeab4e
docs: reference overhaul
kai687 37b77ce
docs: update redocly settings
kai687 cea3fcf
docs: change primary color for API reference
kai687 3c65e26
docs: improve Search API reference
kai687 9029b64
fix: no default value for language enum
kai687 7843ecd
fix: language must be nullable
kai687 830e2f8
fix: not null as an array
kai687 f512cf3
fix: no language enum for now
kai687 d5859e5
fix: no format date-time for now
kai687 af92092
Merge branch 'main' into docs/reference-overhaul
kai687 d94472e
fix: no sortFacetValuesBy enum for now
kai687 18791a4
fix: update yarn website script
kai687 0d39c7c
docs: search api hopefully done
kai687 6188c4a
fix: remove attributes from test
kai687 058ed47
fix search dictionary response
millotp 53a868b
Merge branch 'main' into docs/reference-overhaul
kai687 ee50585
Update specs/search/paths/rules/clearRules.yml
kai687 a934041
docs: update helpers docs
kai687 bf48362
docs: update get settings
kai687 c5ef13a
fix: rename CSharp to C#
kai687 d30872e
Merge branch 'main' into docs/reference-overhaul
kai687 2b59c41
Revert "fix: rename CSharp to C#"
kai687 324cd9d
Merge branch 'main' into docs/reference-overhaul
shortcuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can replace all > with pipes to preserve formatting, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done it for the Search API and common. Will do it for the rest in separate PRs when updating the docs for the other APIs.
Curiously, the
|
doesn't appear in the bundled specs. Something in the process of formatting and writing the spec changes this. I couldn't find any formatting artifacts on the website due to this, so I'm not sure what's going on here.