-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): usage api #2954
fix(specs): usage api #2954
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks wonderful!
appId: | ||
$ref: '../common/securitySchemes.yml#/appId' | ||
apiKey: | ||
$ref: '../common/securitySchemes.yml#/apiKey' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's really this and not basic? if so we will be able to generate clients then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shortcuts I thought the Usage API isn't part of the SDKs?
The current/old API reference in the docs say that it uses the x-algolia-*
headers and not basic auth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's not because generating clients only works with the appID and apiKey combo for now, but since it doesn't use the basic auth anymore, we can make a client for it!
nice my fix worked :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a ton!!
🧭 What and Why
Update of the Usage API spec.
Unfortunately, I can't test the Usage API (can't make any requests) so I can't independently verify the information like I did for the other APIs, so I only did a few style updates.
Changes included:
{statistics}
parameter