Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add algoliaInsights auth type #2959

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

jkaho
Copy link
Contributor

@jkaho jkaho commented Apr 5, 2024

⚠️ Merge when https://github.com/algolia/data-ingestion/pull/2723 goes to prod.

🧭 What and Why

Add algoliaInsights auth type for GA4 BigQuery connector

🎟 JIRA Ticket: EEX-1038

Changes included:

Add AuthAlgoliaInsights and AuthAlgoliaInsightsPartial

@jkaho jkaho requested a review from a team as a code owner April 5, 2024 01:49
@jkaho jkaho requested review from damcou and Fluf22 April 5, 2024 01:49
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 5, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link

github-actions bot commented Apr 5, 2024

@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 02:04 Inactive
@shortcuts
Copy link
Member

We can merge already @jkaho and trigger the release later, wdyt?

@jkaho
Copy link
Contributor Author

jkaho commented Apr 5, 2024

@shortcuts sure, if you think that's safe 👍

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@github-actions github-actions bot temporarily deployed to pull request April 5, 2024 12:31 Inactive
@shortcuts shortcuts merged commit 0348669 into main Apr 5, 2024
24 checks passed
@shortcuts shortcuts deleted the EEX-1038/add-algolia-insights-auth-type branch April 5, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants