Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update support link #2986

Merged
merged 3 commits into from
Jun 5, 2024
Merged

chore: update support link #2986

merged 3 commits into from
Jun 5, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Apr 10, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2412

Changes included:

apply support team recommendations from algolia/algoliasearch-client-javascript#1527

@shortcuts shortcuts self-assigned this Apr 10, 2024
@shortcuts shortcuts requested a review from a team as a code owner April 10, 2024 13:23
@shortcuts shortcuts requested review from damcou and millotp April 10, 2024 13:23
@shortcuts shortcuts enabled auto-merge (squash) April 10, 2024 13:23
@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 10, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp reviewed Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is weird IMO, we still need an email in some places, and the ticket link should only be used when we explicit redirect to support

CONTRIBUTING.md Show resolved Hide resolved
clients/algoliasearch-client-python/setup.cfg Outdated Show resolved Hide resolved
clients/algoliasearch-client-ruby/algolia.gemspec Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

🚀 Deployed on https://66601f4886974fd3138295e9--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 10, 2024 13:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2024 08:18 Inactive
millotp
millotp approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg

@shortcuts shortcuts merged commit af75c55 into main Jun 5, 2024
19 checks passed
@shortcuts shortcuts deleted the chore/support-link branch June 5, 2024 08:20
@algolia-bot algolia-bot mentioned this pull request Jun 11, 2024
Closed
@millotp millotp mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp