Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ruby): scope to last commit #3266

Merged
merged 2 commits into from
Jun 27, 2024
Merged

chore(ruby): scope to last commit #3266

merged 2 commits into from
Jun 27, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 27, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2535

Changes included:

seems like fixes were released on https://github.com/rubygems/release-gem but not tagged, we can try pointing to last commit to see if it works, also that's what they use https://github.com/segiddins/rubygems-await/blob/main/.github/workflows/push_gem.yml, recommended from https://guides.rubygems.org/trusted-publishing/adding-a-publisher/

@shortcuts shortcuts self-assigned this Jun 27, 2024
@shortcuts shortcuts requested a review from a team as a code owner June 27, 2024 14:15
@shortcuts shortcuts requested review from morganleroi and Fluf22 June 27, 2024 14:15
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 27, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts enabled auto-merge (squash) June 27, 2024 14:18
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

Copy link

@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 14:40 Inactive
@shortcuts shortcuts merged commit 95e4c1e into main Jun 27, 2024
12 checks passed
@shortcuts shortcuts deleted the chore/ruby-scope-release branch June 27, 2024 14:40
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jun 27, 2024
algolia/api-clients-automation#3266

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants