-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(specs): add v2 endpoints for ingestion #3416
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d26946b
feat(specs): add v2 endpoints for ingestion
shortcuts 14789e9
fix: params
shortcuts 0ed5e92
fix: parameters
shortcuts ea7607b
fix: csharp ambiguous
shortcuts dbea7e8
fix: swifty nifty annoyingly duplicaty?
shortcuts 3420652
chore: maybe this import
shortcuts d503f07
chore: ok this
shortcuts 6820f87
chore: goood
shortcuts 41894f8
fix: remove v1 push
shortcuts 6574f54
Merge branch 'main' into feat/ingestion-push-endpoint
shortcuts 3ad7b39
chore: unused param
shortcuts a8f6289
Merge branch 'main' into feat/ingestion-push-endpoint
shortcuts 73b9db6
chore: def
shortcuts da8b588
Merge branch 'main' into feat/ingestion-push-endpoint
shortcuts 4399aa4
Merge branch 'main' into feat/ingestion-push-endpoint
shortcuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
batchWriteParams: | ||
title: batchWriteParams | ||
description: Batch parameters. | ||
type: object | ||
additionalProperties: false | ||
properties: | ||
requests: | ||
type: array | ||
items: | ||
title: batchRequest | ||
type: object | ||
additionalProperties: false | ||
properties: | ||
action: | ||
$ref: '#/action' | ||
body: | ||
type: object | ||
description: Operation arguments (varies with specified `action`). | ||
example: | ||
name: Betty Jane McCamey | ||
company: Vita Foods Inc. | ||
email: betty@mccamey.com | ||
required: | ||
- action | ||
- body | ||
required: | ||
- requests | ||
example: | ||
batch: | ||
summary: Batch indexing request | ||
value: | ||
requests: | ||
- action: addObject | ||
body: | ||
name: Betty Jane McCamey | ||
company: Vita Foods Inc. | ||
email: betty@mccamey.com | ||
- action: addObject | ||
body: | ||
name: Gayla geimer | ||
company: Ortman McCain Co. | ||
email: gayla@geimer.com | ||
|
||
action: | ||
type: string | ||
enum: | ||
- addObject | ||
- updateObject | ||
- partialUpdateObject | ||
- partialUpdateObjectNoCreate | ||
- deleteObject | ||
- delete | ||
- clear | ||
description: Type of indexing operation. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
post: | ||
tags: | ||
- tasks | ||
summary: Push a `batch` request payload through the Pipeline | ||
description: Push a `batch` request payload through the Pipeline. You can check the status of task pushes with the observability endpoints. | ||
operationId: pushTask | ||
x-acl: | ||
- addObject | ||
- deleteIndex | ||
- editSettings | ||
parameters: | ||
- $ref: '../../../common/parameters.yml#/pathTaskID' | ||
requestBody: | ||
description: Request body of a Search API `batch` request that will be pushed in the Connectors pipeline. | ||
content: | ||
application/json: | ||
schema: | ||
$ref: '../../../../common/schemas/Batch.yml#/batchWriteParams' | ||
required: true | ||
responses: | ||
'200': | ||
description: OK | ||
content: | ||
application/json: | ||
schema: | ||
$ref: '../../../common/schemas/run.yml#/RunResponse' | ||
'400': | ||
$ref: '../../../../common/responses/BadRequest.yml' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
[ | ||
{ | ||
"parameters": { | ||
"taskID": "6c02aeb1-775e-418e-870b-1faccd4b2c0f", | ||
"batchWriteParams": { | ||
"requests": [ | ||
{ | ||
"action": "addObject", | ||
"body": { | ||
"key": "bar", | ||
"foo": "1" | ||
} | ||
}, | ||
{ | ||
"action": "addObject", | ||
"body": { | ||
"key": "baz", | ||
"foo": "2" | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"request": { | ||
"path": "/2/tasks/6c02aeb1-775e-418e-870b-1faccd4b2c0f/push", | ||
"method": "POST", | ||
"body": { | ||
"requests": [ | ||
{ | ||
"action": "addObject", | ||
"body": { | ||
"key": "bar", | ||
"foo": "1" | ||
} | ||
}, | ||
{ | ||
"action": "addObject", | ||
"body": { | ||
"key": "baz", | ||
"foo": "2" | ||
} | ||
} | ||
] | ||
} | ||
} | ||
} | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no I thought so for the swift issue but it's a leftover indeed