Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): dictionary entry for stopwords has type property #3456

Merged
merged 3 commits into from
Aug 5, 2024
Merged

fix(specs): dictionary entry for stopwords has type property #3456

merged 3 commits into from
Aug 5, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Aug 2, 2024

🧭 What and Why

The Search for dictionary entries response includes a "type" field for each dictionary entry, that can be "standard" or "custom".

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 2, 2024 •
edited
Loading

✔️ Code generated!

Name Link
🪓 Triggered by 01cd7280130739fe99b6782f48866e1ab1962a79
🍃 Generated commit 00652a437347aa6e1ecd4cf36e81e7b3f810a3fe
🌲 Generated branch generated/fix/dictionary-entry
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
javascript 1349
php 1345
csharp 988
java 918
ruby 904
python 739
swift 736
kotlin 486
go 445

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

🚀 Deployed on https://66b08cd4388a079ca74ab18e--api-clients-automation.netlify.app

@kai687 kai687 marked this pull request as ready for review August 3, 2024 07:57
@kai687 kai687 requested a review from a team as a code owner August 3, 2024 07:57
@kai687 kai687 requested review from millotp and shortcuts August 3, 2024 07:57
millotp
millotp approved these changes Aug 3, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@shortcuts shortcuts enabled auto-merge (squash) August 5, 2024 08:11
@shortcuts shortcuts merged commit e5d1417 into main Aug 5, 2024
20 checks passed
@shortcuts shortcuts deleted the fix/dictionary-entry branch August 5, 2024 08:29
algolia-bot added a commit that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (#3456) …
62bc809 
…(generated) [skip ci]

Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
e8f4546 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
a0b7eff 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
c9a54c4 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
c8b106a 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
eeebdac 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
05af6cd 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
7ebbfe0 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
b605170 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
2ca0e8d 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
dec552f 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 5, 2024
@algolia-bot @kai687 @shortcuts
fix(specs): dictionary entry for stopwords has type property (generated)
0ac26a6 
algolia/api-clients-automation#3456

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kai687 @algolia-bot @millotp @shortcuts