Skip to content

feat(specs): recursive snippets and highlights result #3497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2723

Changes included:

this is a regression introduced in the generated clients, it's not as good as what js v4 was proposing (a bit broad) but should still be better

contributes to #853 (comment)
closes algolia/algoliasearch-client-javascript#1534

@shortcuts shortcuts self-assigned this Aug 9, 2024
@shortcuts shortcuts requested a review from a team as a code owner August 9, 2024 07:56
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 9, 2024

✔️ Code generated!

Name Link
🪓 Triggered by a558f38edb715bd0fe004897b593a3c5544acdf1
🍃 Generated commit 92a987c591b5e282e989ed09a06aa8b187a72b91
🌲 Generated branch generated/feat/recursive-highlight-snippet-result
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Rate
php 1360
javascript 1353
csharp 1064
ruby 957
java 919
swift 732
python 726
kotlin 491
go 463

Copy link

github-actions bot commented Aug 9, 2024

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work

@shortcuts shortcuts merged commit 4c05200 into main Aug 9, 2024
21 checks passed
@shortcuts shortcuts deleted the feat/recursive-highlight-snippet-result branch August 9, 2024 10:56
algolia-bot added a commit that referenced this pull request Aug 9, 2024
…ted) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 9, 2024
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
algolia/api-clients-automation#3497

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5] HighlightResult and SnippetResult doesn't support nested structure
3 participants