Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a bug report template to github #3606

Merged
merged 5 commits into from
Aug 29, 2024
Merged

chore: add a bug report template to github #3606

merged 5 commits into from
Aug 29, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Aug 28, 2024

🧭 What and Why

Add a common bug report to all child repo, specifying that the code is generated because its not obvious and people don't know where to contribute.

@millotp millotp self-assigned this Aug 28, 2024
@millotp millotp requested a review from a team as a code owner August 28, 2024 13:56
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 28, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 29558fca2ac582bce9f95d5c6c314679967cc0a5
🍃 Generated commit f493f3520d53192f9fabd5e8fa96128d6eaecfd8
🌲 Generated branch generated/chore/bug-report
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1663
php 1466
csharp 1161
java 995
ruby 927
python 764
swift 762
go 566
kotlin 500

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice


> [!IMPORTANT]
> This repository is fully generated and all pull request will be rejected.
> If you wish to contribute, please refer to the [contribution guidelines](https://github.com/algolia/api-clients-automation/blob/main/CONTRIBUTING.md) on the `api-clients-automation` repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a statement to eventually ask people to re-open issue here? at some point, we will close opening issues on those repos

Copy link
Contributor

@Fluf22 Fluf22 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it will ever become obvious why we prevent opening issues on those repo
I think it's on us to redirect from each repo to the mother one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it's in the readme it's fine, but that's a discussion for later

we should still recommend people to open issue instead as that's kind of the goal of a monorepo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, I find it nice to have the issues on each repo, since we have good tooling to report and track them, it's easier for people

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this repo issues should only concern the generation and tooling, not the API clients code directly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case I already mention this repo, I don't think we need more

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you feel otherwise you can always add a commit on this PR !

Copy link
Member

@shortcuts shortcuts Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly ask people to rather open their issue here instead :D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no ahah thats not a good idea

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just informative

Fluf22
Fluf22 previously approved these changes Aug 28, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea

Copy link

github-actions bot commented Aug 28, 2024

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHORT TERM OK???????????????????

gg

@millotp millotp enabled auto-merge (squash) August 29, 2024 11:20
@millotp millotp merged commit 42a9ee3 into main Aug 29, 2024
21 checks passed
@millotp millotp deleted the chore/bug-report branch August 29, 2024 11:35
algolia-bot added a commit that referenced this pull request Aug 29, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Aug 29, 2024
algolia/api-clients-automation#3606

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants