Skip to content

Conversation

@millotp
Copy link
Collaborator

@millotp millotp commented Sep 11, 2024

🧭 What and Why

I forgot about generated commits in my last PR, they should also contribute to the changelog, on behalf of the base commit.

@millotp millotp self-assigned this Sep 11, 2024
@millotp millotp requested a review from a team as a code owner September 11, 2024 16:08
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 11, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1680
php 1497
csharp 1091
python 1000
java 943
ruby 859
swift 769
go 565

Fluf22
Fluf22 previously approved these changes Sep 12, 2024
Copy link
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the default scope to client when it doesn't match? you know the comment from the previous pr

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah I have it in stash I forgot to push

@millotp millotp merged commit ca57501 into main Sep 12, 2024
@millotp millotp deleted the chore/release-generated branch September 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants