chore(python): proper type hinting #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
reviewed
Sep 26, 2024
clients/algoliasearch-client-python/algoliasearch/http/request_options.py
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-python/algoliasearch/http/request_options.py
Outdated
Show resolved
Hide resolved
Fluf22
force-pushed
the
chore/python-typing-improved
branch
3 times, most recently
from
323d00f
to
f8c2ea7
Compare
Fluf22
force-pushed
the
chore/python-typing-improved
branch
2 times, most recently
from
dd8760a
to
fe33ef6
Compare
millotp
reviewed
Oct 3, 2024
Fluf22
force-pushed
the
chore/python-typing-improved
branch
from
d0b497b
to
534fca6
Compare
millotp
reviewed
Oct 3, 2024
| @@ -19,20 +19,10 @@ def snippet_for_{{#lambda.snakecase}}{{method}}{{/lambda.snakecase}}{{testIndex} | |||
| # Call the API | |||
| {{#hasResponse}}response = {{/hasResponse}}client.{{#lambda.snakecase}}{{method}}{{/lambda.snakecase}}({{#parametersWithDataType}}{{> tests/generateParams}}{{/parametersWithDataType}}{{#hasRequestOptions}} request_options={ {{#requestOptions.headers.parameters}}"headers":loads("""{{{.}}}"""),{{/requestOptions.headers.parameters}}{{#requestOptions.queryParameters.parameters}}"query_parameters":loads("""{{{.}}}"""),{{/requestOptions.queryParameters.parameters}} }{{/hasRequestOptions}}) | |||
|
|
|||
| {{#hasResponse}}print(response){{/hasResponse}} | |||
|
|
|||
| # Skip deserialization | |||
There was a problem hiding this comment.
I think this was requested by customers, we need both async and sync in the snippets
There was a problem hiding this comment.
There is still sync/async snippets, it's above your comment
I removed the call to the _with_http_info variant of the method
millotp
force-pushed
the
chore/python-typing-improved
branch
2 times, most recently
from
61f8607
to
1a0d1d0
Compare
algolia-bot
added a commit
that referenced
this pull request
Oct 4, 2024
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 4, 2024
algolia/api-clients-automation#3839 Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Oct 4, 2024
algolia/api-clients-automation#3839 Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-3000 & DI-3005
Changes included: