Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add support for widgets / banners in search for the csharp client #3870

Conversation

Kalmar99
Copy link
Contributor

@Kalmar99 Kalmar99 commented Oct 2, 2024

fix #3869

🧭 What and Why

The csharp client currently does not support Widgets / Banners as part of the RenderingContent model, however this feature is now available in the dashboard / merchandising studio. This PR adds the missing models required for parsing banners from the api response.

Changes included:

Adds the following models:

  • Banner
  • BannerImage
  • BannerImageUrl
  • BannerLink
  • Widgets
    Also added the missing widgets field to the RenderingContent model

@Kalmar99 Kalmar99 requested a review from a team as a code owner October 2, 2024 12:33
@millotp
Copy link
Collaborator

millotp commented Oct 3, 2024

Hey, all the files you edited are generated files, all the files in this folder are generated, can you edit the spec in specs/search please ? You don't to push the generated code, the CI will do it for you

@Kalmar99
Copy link
Contributor Author

Kalmar99 commented Oct 3, 2024

Ah, i dident notice that this was all auto generated 😅 Will update my PR in a bit

@Kalmar99
Copy link
Contributor Author

Kalmar99 commented Oct 3, 2024

I updated the PR now, removing the models and updating the schema, however i am struggling with setting up the environment for building this. Followed your guide as outlined here https://api-clients-automation.netlify.app/docs/setup-repository but running into a very ambiguous error with the linter

Error: command failed: yarn specs:lint common at run (C:\projects\other\api-clients-automation\scripts\common.ts:114:13) at async lintCommon (C:\projects\other\api-clients-automation\scripts\specs\format.ts:28:3) at async buildSpecs (C:\projects\other\api-clients-automation\scripts\specs\index.ts:149:3) at async Command.<anonymous> (C:\projects\other\api-clients-automation\scripts\cli\index.ts:125:5)

Any chance you could look over the schema and try to build it to see if i did it correctly? 😇

@millotp millotp changed the title feat(csharp) add support for widgets / banners in search for the csharp client feat(specs): add support for widgets / banners in search for the csharp client Oct 3, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is red but the changes looks good ! Thanks for the contribution

@Kalmar99
Copy link
Contributor Author

Kalmar99 commented Oct 4, 2024

@millotp Thank you for helping me sort this out! Massive kudos for responding so fast, going to have some thrilled marketers at our company when this is released :)

@millotp millotp merged commit bed1191 into algolia:main Oct 4, 2024
25 of 28 checks passed
algolia-bot added a commit that referenced this pull request Oct 6, 2024
…rp client (#3870) (generated) [skip ci]

Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 6, 2024
…rp client (generated)

algolia/api-clients-automation#3870

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Jonas <42573917+Kalmar99@users.noreply.github.com>
Co-authored-by: Jonas Kalmar Rønning <jonaskalmar.ronning@komplett.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: RenderingContent is missing widgets section
2 participants