Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): Add context to hitsPerPage #3969

Merged
merged 3 commits into from
Oct 14, 2024
Merged

fix(specs): Add context to hitsPerPage #3969

merged 3 commits into from
Oct 14, 2024

Conversation

gazconroy
Copy link
Contributor

🧭 What and Why

In isolation, hitsperPage and page are difficult to understand.

Related links

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DOC-1532

Changes included:

This gives them some context and interrelates them.

@gazconroy gazconroy requested a review from a team as a code owner October 14, 2024 13:42
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 14, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 58519606357b0701f85e42e9b8a7f1640a70a01c
🍃 Generated commit 1803f2a99191c326c5dee2cbd232e93eb89f93b4
🌲 Generated branch generated/fix/hits-per-page
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1669
go 1642
php 1464
csharp 1221
java 1126
python 1023
ruby 881
swift 748

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@millotp millotp enabled auto-merge (squash) October 14, 2024 14:13
@millotp millotp merged commit 5866c29 into main Oct 14, 2024
28 checks passed
@millotp millotp deleted the fix/hits-per-page branch October 14, 2024 15:32
algolia-bot added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 14, 2024
algolia/api-clients-automation#3969

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants