Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): Separators are non-alphanumeric characters #3978

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

gazconroy
Copy link
Contributor

🧭 What and Why

Without context, it's difficult to tell what separatorsToIndex does.

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DOC-1536

Changes included:

Added some context

@gazconroy gazconroy requested a review from a team as a code owner October 16, 2024 11:08
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 16, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 7f221e09b27997bdbeac86de172f893e9d229a00
🍃 Generated commit b68b18206e5958ac2ed6d1d53e94e3b6c76ee957
🌲 Generated branch generated/fix/separators
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1650
go 1598
csharp 1303
java 1129
python 1002
php 899
ruby 892
swift 721

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts shortcuts enabled auto-merge (squash) October 16, 2024 11:53
@shortcuts shortcuts merged commit 1a9b95e into main Oct 16, 2024
27 checks passed
@shortcuts shortcuts deleted the fix/separators branch October 16, 2024 12:10
algolia-bot added a commit that referenced this pull request Oct 16, 2024
…ated) [skip ci]

Co-authored-by: gazconroy <gazconroyster@gmail.com>
Co-authored-by: Gary Conroy <gary.conroy@LON-M3P-GConroy.local>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 16, 2024
algolia/api-clients-automation#3978

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants