Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): update time range number types [skip-bc] #4023

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 23, 2024

🧭 What and Why

🎟 JIRA Ticket: CR-7132

Changes included:

  • timestamps need an int64 to be able to handle date later than 2038

@Fluf22 Fluf22 requested a review from a team as a code owner October 23, 2024 08:37
@Fluf22 Fluf22 requested review from millotp and shortcuts October 23, 2024 08:37
@Fluf22 Fluf22 self-assigned this Oct 23, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 23, 2024

✔️ Code generated!

Name Link
🪓 Triggered by afea12d0565da8d72897e8df2841c6260d5c43cb
🍃 Generated commit d983d84579e9c543ca560bc061d8b21cca4a27bd
🌲 Generated branch generated/fix/search-timerange-int64
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1670
javascript 1622
php 1474
csharp 1348
java 1133
python 1042
ruby 879
swift 753

@Fluf22 Fluf22 changed the title fix(specs): update time range number types fix(specs): update time range number types [skip-bc] Oct 23, 2024
@Fluf22 Fluf22 force-pushed the fix/search-timerange-int64 branch from 1f44b22 to 10757e4 Compare October 23, 2024 14:34
shortcuts
shortcuts previously approved these changes Oct 23, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful catch

@shortcuts shortcuts merged commit 22f49f1 into main Oct 24, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/search-timerange-int64 branch October 24, 2024 07:22
algolia-bot added a commit that referenced this pull request Oct 24, 2024
…ed) [skip ci]

Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Oct 24, 2024
algolia/api-clients-automation#4023

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants