Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): consequence is required when saving rules #4146

Merged
merged 12 commits into from
Nov 26, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Nov 22, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3243

Changes included:

calling the saveRules endpoint without consequences returns a [ERROR] ApiError: A rule must have at least one consequence (consequence.*) (in [0]) (near 1:20)

@shortcuts shortcuts self-assigned this Nov 22, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 22, 2024 14:39
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 22, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 213933c311911cad53b81b3d8325399fcf3092b0
🍃 Generated commit 37172c47b322039b929aca4321dbdfa6adfa460d
🌲 Generated branch generated/fix/search-save-rules
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1669
javascript 1560
php 1524
csharp 1378
python 1127
java 1119
ruby 874
swift 742

@shortcuts shortcuts force-pushed the fix/search-save-rules branch from f7fc31a to b528eb6 Compare November 26, 2024 10:29
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some dependabot work on a Tuesday ✅

@shortcuts
Copy link
Member Author

Doing some dependabot work on a Tuesday ✅

image

the js cache is broken

@shortcuts shortcuts enabled auto-merge (squash) November 26, 2024 12:26
@shortcuts shortcuts merged commit b728c5f into main Nov 26, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/search-save-rules branch November 26, 2024 12:50
algolia-bot added a commit that referenced this pull request Nov 26, 2024
…rated) [skip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 26, 2024
algolia/api-clients-automation#4146

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants