Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): add sourceType to listTasks [skip-bc] #4193

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 2, 2024

🧭 What and Why

Add the sourceType query param to listTasks.

Also fix the type of the type query param in the listRuns endpoint.

@millotp millotp self-assigned this Dec 2, 2024
@millotp millotp requested a review from a team as a code owner December 2, 2024 21:17
@millotp millotp requested review from Fluf22 and shortcuts December 2, 2024 21:17
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 2, 2024

✔️ Code generated!

Name Link
🪓 Triggered by f8bcb3ecbf04d5745dba4d135f373b78700ef667
🍃 Generated commit 46c9238a2bbe572ce251d676f5b2c2444ff2a230
🌲 Generated branch generated/fix/ingestion-qp
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
swift 755

@millotp millotp requested a review from shortcuts December 3, 2024 08:47
@millotp millotp changed the title fix(specs): add sourceType to listTasks fix(specs): add sourceType to listTasks [skip-bc] Dec 3, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@millotp millotp enabled auto-merge (squash) December 3, 2024 09:51
@millotp millotp merged commit 2540528 into main Dec 3, 2024
27 checks passed
@millotp millotp deleted the fix/ingestion-qp branch December 3, 2024 10:02
algolia-bot added a commit that referenced this pull request Dec 3, 2024
… [skip ci]

Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Dec 3, 2024
algolia/api-clients-automation#4193

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
shortcuts pushed a commit that referenced this pull request Dec 3, 2024
… [skip ci]

Co-authored-by: Pierre Millot <millotpierre3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants