Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enterKeyHint): remove check on only Chrome browser #933

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

FabienMotte
Copy link
Contributor

Issue summary

Related issue: #651
Related PR: #916

This issue is still present on Samsung Internet Browser.
This is because this browser is excluded from the isChrome util: https://github.com/algolia/autocomplete/blob/next/packages/autocomplete-core/src/utils/isChrome.ts#L3

Result

Samsung Internet Browser should be detected as Chrome, so enterKeyHint won't be updated and use a fixed value.

@FabienMotte FabienMotte requested review from a team, dhayab and Haroenv and removed request for a team April 5, 2022 10:15
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e38ca0:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
algolia/autocomplete Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

@FabienMotte FabienMotte requested a review from Haroenv April 5, 2022 13:48
@FabienMotte FabienMotte merged commit 93a1fc2 into next Apr 5, 2022
@FabienMotte FabienMotte deleted the fix/enterKeyHint-samsung branch April 5, 2022 14:43
@FabienMotte FabienMotte changed the title fix(enterKeyHint): samsung browser should be detected as chrome fix(enterKeyHint): remove isChrome util Apr 5, 2022
@FabienMotte FabienMotte changed the title fix(enterKeyHint): remove isChrome util fix(enterKeyHint): remove check on only Chrome browser Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants